You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add unit tests for the log display preferences #20188
While writing the test, run just this file so the feedback loop stays fast:
cd ui && npm run test:unit -- tests/unit/composables/useLogDisplay.spec.ts
Proof required in the PR
Important
The PR that closes this issue must include a screenshot of the test passing, pasted into the PR description. Pasted text output is not enough.
To produce it, run the single-file command above and screenshot the terminal. The capture should show the command, the test file, and the green summary lines (Test Files 1 passed (1) and Tests N passed (N)). Then drag the image straight into the PR description field on GitHub, which uploads and embeds it.
What
ui/src/composables/useLogDisplay.tsalready has a spec, but the exports below have no coverage in it.These four preferences persist how the logs view renders. Five of the module's ten exports are uncovered, including every one of the persisted refs.
What to do
Add cases to the existing
ui/tests/unit/composables/useLogDisplay.spec.tscovering:DENSITY_PADDINGhas an entry for every density the picker offersReference
The spec file itself shows the house style;
ui/tests/unit/composables/useTenant.spec.tsis another example.How to run
Install once, then run the whole suite:
While writing the test, run just this file so the feedback loop stays fast:
Proof required in the
PRImportant
The
PRthat closes this issue must include a screenshot of the test passing, pasted into thePRdescription. Pasted text output is not enough.To produce it, run the single-file command above and screenshot the terminal. The capture should show the command, the test file, and the green summary lines (
Test Files 1 passed (1)andTests N passed (N)). Then drag the image straight into thePRdescription field on GitHub, which uploads and embeds it.