Repository navigation
[TF3] Add efficiency, time resolution and ToA maps from ccdb - #15883
Open
GiorgioAlbertoLucia wants to merge 12 commits into
Open
GiorgioAlbertoLucia wants to merge 12 commits into
GiorgioAlbertoLucia wants to merge 12 commits into
Conversation
GiorgioAlbertoLucia
marked this pull request as ready for review
October 1, 2026 13:23
GiorgioAlbertoLucia
requested review from
fcolamar,
mconcas and
njacazio
as code owners
October 1, 2026 13:23
GiorgioAlbertoLucia
marked this pull request as draft
October 1, 2026 14:05
GiorgioAlbertoLucia
force-pushed
the
iotof-digi
branch
from
October 5, 2026 09:29
8d3f932 to
42f544b
Compare
…inimum time resolution is not zero for rescaling
GiorgioAlbertoLucia
force-pushed
the
iotof-digi
branch
from
October 9, 2026 09:48
42f544b to
da9e451
Compare
GiorgioAlbertoLucia
marked this pull request as ready for review
October 9, 2026 10:03
GiorgioAlbertoLucia
requested review from
sawenzel and
shahor02
as code owners
October 9, 2026 10:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maciacco
This pull request introduces improvements to the IOTOF digitizer simulation and a new macro to test the time resolution
Improvements in the digitization
Added support in
DPLDigitizerParamfor specifying optional efficiency, resolution, and time of arrival map paths, which can be loaded from CCDB or various file sourcesUpdated
Digitizerto load these maps using a newloadMapmethod, supporting both CCDB and ROOT file sources, and to prepare a scaled resolution map for position-dependent time resolutionThe time smearing logic in
Digitizer::smearTimenow uses the loaded resolution and time of arrival maps to apply position-dependent Gaussian smearingNOTE: the resolution map determines the relative in-pixel resolution, while the nominal value is set by an independent parameter of the DPLDigitizerParam class
Refactored map loading logic into a generic
loadMapmethod and addedprepareScaledResolutionMapfor normalization, improving code maintainability and extensibility.Fixed a run-time inconsistency in the output size within IOTOFDigitizerSpec.cxx
Testing
CheckTimeResolutionIOTOF.Cto the CMake configuration, ensuring that time resolution features can be tested and validatedEfficiency, time resolution and time of arrival maps can be found in the ccdb at these paths
I will upload some examples of the mean and rms of the time resolution when the maps are used in the digitization


Input resolution map
Observed in-pixel resolution
Input time of arrival map


Observed in-pixel time of arrival