Skip to content

[PWGGAJE] Param Model: better multiplicity model - #2496

Open
aimeric-landou wants to merge 3 commits into
AliceO2Group:masterfrom
aimeric-landou:master
Open

aimeric-landou wants to merge 3 commits into
AliceO2Group:masterfrom
aimeric-landou:master

Conversation

@aimeric-landou

Copy link
Copy Markdown
Contributor

No description provided.

@aimeric-landou
aimeric-landou requested a review from a team as a code owner October 6, 2026 16:42
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@aimeric-landou

Copy link
Copy Markdown
Contributor Author

The syntax issues are from files that I have not edited:

Error found in GRID/utils/getCCDBTimeMachineTimestamp.py line 92:
Error: Value 'result['as_of']' is unsubscriptable
Error found in MC/bin/tests/test_anchoring_rampup.py line 39:
Error: No value for argument 'ITS_rampup' in function call
Error found in MC/bin/tests/test_anchoring_rampup.py line 44:
Error: No value for argument 'ITS_rampup' in function call
Error found in MC/bin/tests/test_anchoring_rampup.py line 50:
Error: No value for argument 'ITS_rampup' in function call
Error found in MC/bin/tests/test_anchoring_rampup.py line 57:
Error: No value for argument 'ITS_rampup' in function call
Error found in MC/bin/tests/test_anchoring_rampup.py line 64:
Error: No value for argument 'ITS_rampup' in function call
Error: Process completed with exit code 123.

@aimeric-landou

Copy link
Copy Markdown
Contributor Author

@nzardosh I think the JE reviewers are not pinged by default on O2DPG;
can you review this? do you know if somebody in JE is assigned to the O2DPG reviews?

@nzardosh

nzardosh commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Hi @aimeric-landou yes I am happy to review but in general I don't know much about the DPG fraemwork. If you can get someone like @jackal1-66 to comment that its ok I am happy to approve it

@jackal1-66

Copy link
Copy Markdown
Collaborator

Ciao @aimeric-landou @nzardosh I checked already the PR yesterday and I was waiting the review of the PWG. I'm trying to understand why Pylint is failing. I'll let you know asap

@vkucera

vkucera commented Oct 8, 2026

Copy link
Copy Markdown

Ciao @aimeric-landou @nzardosh I checked already the PR yesterday and I was waiting the review of the PWG. I'm trying to understand why Pylint is failing. I'll let you know asap

The errors reported by the Pylint check have been fixed in the upstream after this PR was made. GitHub will not update the merge commit (which is tested by the checks) until the PR changes.
So TL;DR, update the PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants