Repository navigation
Prevent Atlas crash when PDBe returns no exact SIFTS mapping - #73
Merged
Merged
Conversation
…essful verification
CedricHermansBIT
marked this pull request as draft
October 9, 2026 16:41
CedricHermansBIT
marked this pull request as ready for review
October 9, 2026 16:41
…nly in crash test
CedricHermansBIT
marked this pull request as draft
October 9, 2026 16:45
CedricHermansBIT
marked this pull request as ready for review
October 9, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The Atlas verifier assumed every successful PDBe updated-mmCIF request contains exact matching SIFTS residue rows. When
rows=[],ram_atlas_exact_sifts_map()returnedram_canonical_empty_map(), which lacks the Atlas-specificobservedcolumn. The subsequentram_atlas_sifts_summary()threwInvalid exact SIFTS mappingoutside the observer'stryCatch.Fix
observed,mon_id,label_seq_id) instead of the incomplete generic mapping.ram_atlas_verified_sifts()to validate and summarize per entity and reject an empty exact mapping with a specific, actionable message, while retaining successful mappings unchanged.Regression
4AKE_1with zero matching SIFTS rows, checks the card error/no Shiny output error, and verifies a valid1CRN_1in the same session.No change to the live Shinylive deployment.