Repository navigation
fix(slack): reject non-finite timing settings and approval waits - #137
Merged
Merged
Conversation
Decode and validate each trace line inside the TraceReadError boundary. Preserve LF, CRLF, CR, Unicode content, blank lines and a valid unterminated last event. Trace, metrics and viz now report invalid UTF-8 as a structured exit-2 error rather than a raw decoding traceback. Fixes #134.
Reject NaN, infinity and overflowing environment durations before bot startup, and reject NaN approval waits at the command gate. Positive fractional values and existing command budgets remain configurable. Update timing documentation and the selected-test figure. Fixes #135.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack currently accepts non-finite environment durations, and a NaN approval wait passes both comparisons against the command's budget. Require finite positive reader/work timeouts and live intervals in
SlackBotConfig.from_env(), and reject non-finite requester-supplied approval waits at the command gate.Keep positive fractional durations, current defaults and existing timeout ceilings configurable. The kernel's separate unlimited-budget semantics are unchanged. Add regression coverage for NaN, infinities, numeric overflow and both approval-flag spellings; document the validation and refresh the selected-test figure.
Validation: 11 cases failed on unmodified main; all 15 new checks now pass. The focused Slack gateway/live/supervision/documentation run passed 134 tests.
ruff check .andgit diff --checkpassed. No Slack network connection or paid model calls were used.Fixes #135.