Repository navigation
Update sql-backup-database to check if $BackupDirectory exists before attempting to create it - #1707
Merged
twerthi merged 3 commits intoOct 6, 2026
Conversation
|
Review this PR in Hyponome for a side-by-side diff of the step-template JSON and any embedded scripts. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change introduced in v14 of sql-backup-database does not check if $BackupDirectory exists before it tries to create it. If it does exist, Powershell will throw a ResourceExists error and exit script execution. This change checks if the folder exists and only tries to create it if it does not exist by changing:
New-Item -Path (Split-Path $BackupDirectory) -Name (Split-Path $BackupDirectory -Leaf) -ItemType Directory
to:
$backupDirExists = Test-Path -Path $BackupDirectory
if (-not $backupDirExists) {
New-Item -Path (Split-Path $BackupDirectory) -Name (Split-Path $BackupDirectory -Leaf) -ItemType Directory | Out-Null
}