Repository navigation
Local-module debug builds shadow boarddev with displaydev - #17
Merged
Merged
Conversation
displaydev reads its PYDEVICES_* settings through boarddev's env helpers since pydevices moved them there (a hard break), so a local displaydev over an older TestPyPI pydevices would fail on its first env read. The debug sync copies boarddev.py beside it and the default build removes it. usdl2 is read from pydevices/utils/, where it lives now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyDevices/pydevices#131 moves the env helpers from displaydev to boarddev as a hard break, and displaydev now reads its
PYDEVICES_*settings through boarddev. With--local-modules, this build put a local displaydev over the TestPyPI pydevices, so a new displaydev would have met an old boarddev that has noenv_int. The debug sync now copiesboarddev.pybeside displaydev, and the default build removes it with the other shadows.While I was there I fixed one more thing:
usdl2.pyis read frompydevices/utils/, where it lives now. The olddrivers/path made the debug sync skip it.Merge order: after PyDevices/pydevices#131. The default build (no
--local-modules) is unaffected either way.Tested: I ran
sync_android_display_modulesandclear_android_local_module_shadowsagainst #131's checkout and a scratchAPP_DIR. Bothdisplaydev/andboarddev.pywere staged, then both were removed.bash -nis clean. I didn't build an APK.