Repository navigation
Pin pydevices-lvgl to 9.5.48, beside pydevices 0.5.2 - #21
Merged
Merged
Conversation
The recipe left pydevices-lvgl unpinned, and its get_pip_name dropped any version, so a build today takes 9.5.49. That release no longer ships display_driver, which moved into pydevices 0.7; with pydevices pinned at 0.5.2 an app that imports display_driver would find neither copy. Pin 9.5.48 (the last that carries it) and make get_pip_name honour the pin. This is android-runner's recipe, copied unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pydevices-lvgl recipe was unpinned, and its
get_pip_namedropped any version, so a build today takes pydevices-lvgl 9.5.49. That release no longer shipsdisplay_driver: it moved into pydevices 0.7. This template pins pydevices 0.5.2, so an app here that importsdisplay_driver(any LVGL app) would find neither copy.This pins 9.5.48, the last release that carries it, and makes
get_pip_namehonour the pin. The recipe is android-runner's, copied unchanged, as it pinned the same way for the same reason. 9.5.48'sdisplay_driverimportsappdev,events,keysandmultimer.ticks_ms, which pydevices 0.5.2 has. Move the two pins together when the template moves to pydevices 0.7.Checked:
scripts/check_recipe_pins.pyresolvespydevices-lvgl==9.5.48. An APK built from this branch with./build_android.sh -y(arm64-v8a only, to reuse a recipe cache) ran pip withpydevices-lvgl==9.5.48, carriespydevices_lvgl-9.5.48anddisplay_driver, and started on a Galaxy S21 (Android 14): the demo's four colour bands drew and the log printed "PyDevices Android Template running".The audiodsp recipe has the same
get_pip_nameproblem (that build took audiodsp 0.6.4, not 0.6.0); that's android-runner#37.