Repository navigation
The audiodsp recipe honours its pin, now 0.6.4 - #22
Merged
Merged
Conversation
get_pip_name() returned the bare name, so p4a installed the newest audiodsp on the index whatever the pin said. It now returns pydevices-audiodsp==<version>, the way the lvgl recipe does. 0.6.4 is the latest final and what an unpinned build has been taking.
p4a matches the existing dist by recipe names alone and repackages the old packages. Remove the dist and the old dist-info, and check what the APK carries.
Contributor
Author
|
Built from this branch with The second commit documents a trap found on the way: an incremental build ignores a changed recipe pin, because p4a reuses the dist when the recipe names match. The Runner hit it moving pydevices-lvgl (PyDevices/android-runner#39). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pydevices-audiodsprecipe named0.6.0, but itsget_pip_name()returned the bare package name, so p4a ranpip install pydevices-audiodspand took whatever was newest on TestPyPI. A fresh build took 0.6.4.get_pip_name()now returnspydevices-audiodsp==<version>when a version is set, the way the pydevices-lvgl recipe does, and the pin moves to 0.6.4, the latest final and what unpinned builds have been shipping. The other pins stay where they are.Same fix as PyDevices/android-runner#37.
Tested: an APK built from this branch with
./build_android.sh -y(results in a comment below).