Repository navigation
perf(@angular/build): reuse extendedConfigCache in TypeScript compilation - #34192
Merged
alan-agius4 merged 1 commit intoOct 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a caching mechanism for the TypeScript configuration in the Angular build process to improve performance during watch mode rebuilds. The reviewer suggests enhancing this cache by tracking the 'rootFiles' to ensure the cache is properly invalidated when the set of root files changes, preventing potential compilation errors or stale configurations. All review comments are actionable and provide necessary improvements to the implementation.
alan-agius4
force-pushed
the
perf/cache-transformed-configuration
branch
from
September 29, 2026 07:45
58616e8 to
440fe64
Compare
alan-agius4
force-pushed
the
perf/cache-transformed-configuration
branch
from
October 1, 2026 09:44
ba48b1a to
168aa51
Compare
alan-agius4
force-pushed
the
perf/cache-transformed-configuration
branch
from
October 8, 2026 16:52
168aa51 to
2738cc3
Compare
…tion Reusing TypeScript's extendedConfigCache across watch rebuilds eliminates redundant reading and re-parsing of extended tsconfig files from disk. The referenced configuration files are also tracked so that entries in the cache are invalidated when those files change on disk. See: angular/angular#71034
alan-agius4
force-pushed
the
perf/cache-transformed-configuration
branch
from
October 8, 2026 17:37
2738cc3 to
5e38c6e
Compare
dgp1130
approved these changes
Oct 8, 2026
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing TypeScript's
extendedConfigCacheacross watch rebuilds eliminates redundant reading and re-parsing of extended tsconfig files from disk.The referenced configuration files are also tracked so that entries in the cache are invalidated when those files change on disk.
See: angular/angular#71034