Repository navigation
test(mosaic): fix flaky profile picture and invitation revoke feature tests - #10177
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6af309f The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe profile-picture test now waits for the file input to become enabled after uploading a picture and seeing the manage-picture button. The changeset file gains two YAML document delimiters with no content between them. Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The test now waits for the first upload to finish before making the second pick, addressing the reported flake. No actionable merge risk remains. Pre-merge checks |
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
Fixes a flake in
user-profile-profile-section.feature.test.tsx› "replaces a rejected pick with why removing the picture failed".The test waits for the "Manage profile picture" button after the first upload, then uploads an oversized file.
FileUpload.Rootisdisabledwhile an upload is pending, so if the button appears before the first upload settles, the second pick is ignored and no alert shows (likely cause; not observed directly). The test now also waits for the file input to be enabled before the second pick.Before: failed on #10153's CI and in 3 of 6 local full feature-suite runs. After: 6 of 6 local full runs pass.
Also fixes a flake in
organization-profile-invitations.feature.test.tsx› "keeps the dialog open with the server message when the invitation is no longer pending" (failed on this PR's CI).Card.Banneralways renders itsrole="alert"wrapper, empty until a message arrives, sofindByRole('alert')can resolve on the empty region and the text assertion fails without retrying. The two invitation-revoke assertions and one members-panel assertion now usewaitFor(() => expect(getByRole('alert')).toHaveTextContent(...)), the pattern used elsewhere in the suite.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change