Repository navigation
Conversation
…erSuite) also, introduce hook aliases global.GherkinBefore and global.GherkinAfter because gherkin hooks types are incompatible with mocha global.Before and global.After
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Improve types of global hooks - Background, Before, After, BeforeSuite, AfterSuite.
Now hook callback's argument includes type for
{ suite }field.And for Background, Before, After only - type for
{ test }field.Also introducing aliases GherkinBefore and GherkinAfter for existing Before and After hooks, because types of gherkin Before/After are incompatible with types of mocha Before/After.
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)