Repository navigation
Conversation
Replace the standalone claude-code-action review workflow with the canonical caller stub for the shared harness, pinned to @v2, with verdict_policy: deterministic. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The shared review harness base prompt owns review behavior, so the 'only comment when actionable' line restates it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Kaktug
approved these changes
Oct 6, 2026
…w prompt The harness posts an APPROVE verdict for a clean review under verdict_policy: deterministic, so a repo-prompt instruction to post no comment at all on a clean PR conflicts with it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The base prompt already owns severity tiers, review behavior, confidence scoring, previous-review handling and generated-file filtering. This prompt was an unmodified template with no repo-specific rules, and parts of it (Critical/Question severities, "phrase uncertainty as a question") conflict with the base prompt, so only the heading and intro remain. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Author
|
Closing: moqueue is a public repo, and GitHub does not allow public repos to call reusable workflows stored in private repos, so the shared review harness (customink/agent-first-standards, private) cannot run here. Merging this would replace the working legacy review workflow with one that fails to start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stakeholder Overview
Replaces moqueue's standalone
claude-code-actionreview workflow with the shared CustomInk PR review harness (customink/agent-first-standards, pinned to@v2). The harness owns the diff and previous-review fetching, prompt assembly, posting and trust boundary that this repo's workflow was doing by hand.Trust boundary / first exercise: the harness skips the real review on a PR that edits the review stub, so
review / codeon this PR is not evidence the setup works. The new configuration is first exercised on the first PR after merge.Risk Estimate
✅ Negligible risk!
CI-only change to a gem's review tooling; no library code changes. Branch protection on
master, verified withgh api:required_status_checks: none (checks: [],contexts: [], enforcementoff);/rules/branches/masterreturns[]. Nothing requires the old or new check name.required_approving_review_count: 0,require_code_owner_reviews: false,enforce_admins: true.REQUEST_CHANGESreview posted by the harness would block merging under these settings.Click to expand!
Commit 1: migrate PR review to the shared review harness (v2)
.github/workflows/claude-code-review.ymlremoved and.github/workflows/code-review.ymladded with the canonical stub from the harness'sADOPTING.md(## The stub), plusverdict_policy: deterministic. Git shows this as a delete plus an add, not a rename, because the content is almost entirely different.review, so the check readsreview / code.closedis inpull_requesttypes (lifecycle telemetry). Permissions areactions: read,contents: read,pull-requests: write,issues: write.Commits 2 and 3: trim
.claude/review-prompt.mdOnly comment when you have actionable feedback. Never post "looks good"..., which restates reviewer behavior the base prompt owns. A second commit removes the bullet "If the entire PR looks good, do not post a comment at all" (it conflicts with the harness posting anAPPROVEfor a clean review underverdict_policy: deterministic). A third commit trims the rest of the file down to its heading and intro line: the prompt was an unmodified template with no repo-specific rules, and the harness base prompt already covers its content (severity tiers, review behavior, confidence scoring, previous-review handling, generated-file filtering). Parts of it conflicted with the base prompt (the Critical/Question severities, and "phrase uncertainty as a question" versus the base prompt dropping low-confidence findings). The file is kept rather than deleted, so repo context now comes only fromCLAUDE.md. Also dropped with it: the generic "What to Evaluate" list, the PR Context line, and the "flag change hygiene" and "call out good choices" bullets, which the base prompt does not cover.Notes
Dropped from the legacy workflow
issue_comment/pull_request_review_comment/pull_request_reviewtriggers:@claudecomment-triggered re-review no longer works. The stub triggers only onpull_request.--allowedToolslist,--max-turns 10, and thevars.CLAUDE_REVIEW_MODELmodel-selection step (harness owns tools, turns and model; nomodel,max_turnsor otherwith:inputs are carried over besidesverdict_policy).concurrencyblock.if:conditions andid-token: write.issues: readbecameissues: write.continue-on-error: true: previously a failed review never failed the job. Withverdict_policy: deterministicthe harness can postREQUEST_CHANGESorAPPROVE(blocking findings giveREQUEST_CHANGES, clean givesAPPROVE). See the branch-protection facts above.allowed_bots: "custom-ink-triton": the harness usesallowed_bots: "*"withdenied_botsdefaulting todependabot[bot],renovate[bot], so other non-denied bots' PRs (including custom-ink-triton) are now also reviewed.AGENTS.md: the legacy "Build review prompt" step concatenated
AGENTS.md,CLAUDE.mdand.claude/review-prompt.md. The rootCLAUDE.mdonly contains@AGENTS.md, andAGENTS.mdholds the repo context. Whether the harness resolves that@AGENTS.mdimport was NOT verified (AGENTS.mdis not named in the harness'spr-review.ymlorADOPTING.md). It will be first exercised on the first PR after merge; if reviews lack repo context, fold the essentials into.claude/review-prompt.md.Other workflows:
.github/workflows/rubocop.yml(reviewdog RuboCop lint reporter) is not an AI reviewer and is left unchanged.stale.ymlis unrelated.Not run: the skill's Step 6 local dry-run was not run.
Surviving path filters: none. No
claude_md_globis set (no sub-directoryCLAUDE.mdfiles). CODEOWNERS is* @customink/premium-blend.Rollout: do not make
review / codea required status check (per the harness'sdocs/ADOPTING.md: the harness skips drafts, stub-modifying PRs, denied bots and duplicate SHAs, and a skipped workflow never reports a status, which blocks merging when required).review_mode: blockingis available if suggestion churn becomes a problem.🤖 Generated with Claude Code