Repository navigation
Desktop fee form refetch - #1468
Merged
julian-CStack merged 3 commits intoOct 8, 2026
Merged
Conversation
Cyrix126
force-pushed
the
desktop_fee_form_refetch
branch
from
October 8, 2026 02:41
f800809 to
90c91bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop fee form fetches fees in the build of the form, so every rebuild of the send view started a new fee-rate request.
Also while fetching, nothing use the amount in sendAmountProvider (the estimated field is only showing "Calculating", which doesn't require the amount), so the amount stored for the estimate is reset to 0 (different from the amount in the field that the user can see), which makes and leaves an estimated fee for an amount of 0, unless the user leaves the amount field again. It does not impact the send itself.