Repository navigation
ci: fix multipart regression lint failures - #379
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 69.85% 69.51% -0.34%
==========================================
Files 80 80
Lines 4229 4229
Branches 1521 1521
==========================================
- Hits 2954 2940 -14
- Misses 366 372 +6
- Partials 909 917 +8 see 13 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw multipart upload regression helper introduced three cpplint
runtime/intfailures, leaving Verify Build red. Add scoped annotations for thelongtypes required by libcurl's POSTFIELDSIZE and response-code APIs, with a rationale matching the existing upload helpers.Validation: reproduced the three CI failures twice before the change; the full recursive cpplint command now passes. Warning-suppression and file-size gates pass, and
git diff --checkis clean. This changes only comments and ChangeLog; executable test behavior is unchanged.