Repository navigation
Make OTLP_ENDPOINT_ENV_VARS module-private - #9470
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The narrow visibility change preserves internal behavior and has appropriate regression coverage; tests were not run.
Review effort: Balanced
Findings: None
What changed in this PR
Makes OTLP_ENDPOINT_ENV_VARS module-private, addressing #9465 without changing endpoint resolution behavior.
Changes:
- Removes the constant’s export.
- Adds a regression assertion that it is absent from module exports.
| File | Description |
|---|---|
| src/api-proxy-config-domains.ts | Makes the endpoint variable list private. |
| src/api-proxy-config-domains.test.ts | Verifies the constant is not exported. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
✅ Copilot review passed with no inline comments. @copilot Add the |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed...
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅
|
|
Smoke Cloud Hypervisor completed. Cloud Hypervisor + Copilot passed.
|
|
✅ Build Test Suite completed successfully!
|
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓
|
|
✅ Smoke Claude passed
|
|
🔌 Smoke Services — All services reachable! ✅
|
|
🚀 Security Guard has started processing this pull request |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...
|
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... Smoke test incomplete: builtins-only shell available; missing
|
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤
|
Smoke Test: Cloud Hypervisor + Copilot
All checks passed.
|
|
Services smoke test: ✅ Redis PONG · ✅ pg_isready accepting connections · ✅ SELECT 1 = 1. PASS
|
|
EGRESS_RESULT allow=pass deny=pass
Overall: PASS —
|
Smoke Test: Copilot BYOK (Direct) Mode✅ 1. GitHub MCP Testing — Retrieved 2 recent PRs, data matches pre-fetched results Overall Status: PASS
|
Smoke Test: Claude Engine Validation
Overall result: PASS
|
|
Smoke Copilot: PASS
|
|
OTEL smoke test (re-run locally)
|
Chroot Version Comparison
Node.js differs between host and chroot, so the tests did not all pass and the
|
🏗️ Build Test Suite Results
Overall: 6/8 ecosystems passed — FAIL Failures
The
|
OTLP_ENDPOINT_ENV_VARSis exported despite having no consumers outside its defining module or documented public API role.export; preserve OTLP endpoint resolution behavior.