Repository navigation
Conversation
see #4071. see <https://rust-lang.github.io/rust-clippy/master/index.html#rest_pattern_accessible_field>. this lint disallows `..` patterns for accessible fields. this is helpful because it calls attention to locations that may need to be updated when the contents of a structure changes. allowances are left in place for simple accessors. because the lint_reason feature is not supported across the range of our MSRV, we use `/*reason: explanation*/` comments for now. an explicit allowance of `unneeded_field_pattern` is added, because these two lints conflict: we can either expect exhaustive matching, or we can expect that no fields are explicitly ignored. the former is more verbose, but draws attention to where logic may need to be updated as a type evolves over time. Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
marked this pull request as ready for review
October 10, 2026 04:07
dswij
reviewed
Oct 11, 2026
dswij
left a comment
dswij
left a comment
Member
There was a problem hiding this comment.
Actually still torn on this. Not sure if I completely like defaulting to exhaustive matching, but I wouldn't mind it either. 🤔
dswij
reviewed
Oct 11, 2026
| } | ||
| } | ||
|
|
||
| #[allow(clippy::rest_pattern_accessible_field/*reason: this is an accessor*/)] |
Member
There was a problem hiding this comment.
After rustc version 1.81.0 this can use expect and lint reason
#[expect(clippy::rest_pattern_accessible_field), reason = ".."]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #4071.
see https://rust-lang.github.io/rust-clippy/master/index.html#rest_pattern_accessible_field.
this lint disallows
..patterns for accessible fields. this is helpfulbecause it calls attention to locations that may need to be updated when
the contents of a structure changes.
allowances are left in place for simple accessors. because the
lint_reason feature is not supported across the range of our MSRV, we
use
/*reason: explanation*/comments for now.an explicit allowance of
unneeded_field_patternis added, becausethese two lints conflict: we can either expect exhaustive matching, or
we can expect that no fields are explicitly ignored. the former is more
verbose, but draws attention to where logic may need to be updated as a
type evolves over time.