Repository navigation
chore(deps): bump testify to v1.12.1 - #3166
Open
hoangtaiki wants to merge 1 commit into
Open
hoangtaiki wants to merge 1 commit into
hoangtaiki wants to merge 1 commit into
Conversation
testify v1.12.0 dropped github.com/pmezard/go-difflib and github.com/davecgh/go-spew (both unmaintained), and v1.12.1 moved YAML support from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3. Echo only uses testify in tests, so there is no runtime change. After this bump go-difflib, go-spew and gopkg.in/yaml.v3 are no longer in the module graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
github.com/stretchr/testifyfrom v1.11.1 to v1.12.1.github.com/pmezard/go-difflibis no longer maintained (last release v1.0.0, January 2016). Echo does not import it directly. It came in throughtestify/assert, which uses it to print the diff whenassert.Equal,EqualValuesorExactlyfail.testify v1.12.0 dropped
go-difflibandgo-spew. v1.12.1 also moved YAML support from the unmaintainedgopkg.in/yaml.v3togo.yaml.in/yaml/v3.Changes
Only
go.modandgo.sumchange.github.com/pmezard/go-difflib,github.com/davecgh/go-spew,gopkg.in/yaml.v3go.yaml.in/yaml/v3v3.0.5Risk
Low. testify is only used in
_test.gofiles, so there is no runtime or public API change. The testify v1.12.x releases have no breaking API changes and no Go version bump. Consumers of echo/v5 will see testify v1.12.1 as the minimum testify version in their module graph.Testing
go build ./...go vet ./...go test -race ./...(root,echotest,middleware) all passgo mod verifygo mod graphno longer listsgo-difflib,go-speworgopkg.in/yaml.v3