Skip to content

fix(locator): pass the timeout through in screenshot #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into from
Oct 8, 2026
+15 −0
Merged

fix(locator): pass the timeout through in screenshot #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions playwright/_impl/_locator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,7 @@ async def screenshot(
lambda h, timeout: h.screenshot(
**{**params, "timeout": timeout},
),
timeout,
)

async def aria_snapshot(
Expand Down
7 changes: 7 additions & 0 deletions tests/async/test_locators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,13 @@ async def test_locators_should_screenshot(
)


async def test_locators_screenshot_should_respect_timeout(page: Page) -> None:
page.set_default_timeout(5_000)
await page.set_content("<div>hello</div>")
with pytest.raises(Error, match="Locator.screenshot: Timeout 500ms exceeded."):
await page.locator("#missing").screenshot(timeout=500)


async def test_locators_should_return_bounding_box(page: Page, server: Server) -> None:
await page.set_viewport_size(
{
Expand Down
7 changes: 7 additions & 0 deletions tests/sync/test_locators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,13 @@ def test_locators_should_screenshot(
)


def test_locators_screenshot_should_respect_timeout(page: Page) -> None:
page.set_default_timeout(5_000)
page.set_content("<div>hello</div>")
with pytest.raises(Error, match="Locator.screenshot: Timeout 500ms exceeded."):
page.locator("#missing").screenshot(timeout=500)


def test_locators_should_return_bounding_box(page: Page, server: Server) -> None:
page.set_viewport_size(
{
Expand Down
Loading