Repository navigation
fix(page): accept numeric width, height and margin in pdf - #3233
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 8, 2026
Merged
Conversation
Pavel Feldman (pavelfeldman)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.pdfsent numericwidth,heightandmarginvalues unchanged, and the driver rejected them withexpected string, got number. Numbers are now sent aspxstrings, as the JS client does, sowidth=500matcheswidth="500px".Fixes microsoft/playwright#43207