Repository navigation
fix: drop redundant cast flagged by ty 0.0.85 - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #151
ty 0.0.85 infers
dict.fromkeys(deps, "service_started")asdict[str, str], so thecastincompose2pod/graph.pyis redundant andty checknow fails on theredundant-castwarning. The repo runs no other type checker that needs the cast.Changes
castin_declared_depends_onand the unusedcastimport.Checklist
just lint-cipasses (failed on the warning before the change)just test-cipasses (1580 passed, 100% coverage)