Repository navigation
Add a Russian translation and a theme switch to the page - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback from the first GitLab trial asked for Russian and a light theme.
localStorage; the page works without it.index.html. Counts useIntl.PluralRules, so Russian gets its three forms ("1 задача", "2 задачи", "5 задач").<head>before the first paint, so a stored choice does not flash. Dark colours are defined twice: underprefers-color-scheme: darkunless light is forced, and under[data-theme="dark"].Not translated: warnings and errors from
collect, and texts from GitLab and Jira (titles, statuses, summaries). Translating collector messages would need message codes in the report schema; GitLab and Jira errors cannot be translated by the page at all, and engineers search for them by their original wording.Checked in a browser against a fixture report: both languages, all three themes, persistence across reloads, no console errors.