Repository navigation
Clickable links in warnings and errors - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLs in collector messages (GitLab settings and members pages in the CI/CD and Environments warnings and in the 403 checklist) are now links on the page, in both languages.
messageParts(item)splits the rendered message, Englishtextor the Russian rendering, into text and URL parts. Onlyhttp(s)://runs become links, and trailing punctuation such as.or).stays outside the link.x-if, so the DOM holds one element per part, andpre-linestill keeps the 403 checklist on separate lines.<base target="_blank">.Linkifying the rendered text rather than the URL params covers both languages and any future message without per-code markup.
Checked in the browser with the schema 4 fixture: the 403 checklist shows three working links in English and Russian, plus punctuation edge cases.