Repository navigation
Count failed jobs of the shown tag only on the service line - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service line counted every failed job between production and the head: every row's main pipeline and every tag pipeline, including untagged rows above the newest tag. A failure fixed a few merges later, or one in a commit no tag ships yet, kept the count red even when the tag about to be released was green.
The line now counts only the jobs of the tag it is about:
1.2.0: ❌ 1 failed) since the line does not show that tag otherwise;Allowed-to-fail jobs are still counted separately. The failed-jobs column of the opened service is unchanged, so the failures of other rows stay one click away. Page only: the report and its schema are unchanged.
The page's JavaScript has no tests, so I checked it in a browser against a sample report with failures in three rows. Before a pick the line read
1.2.0: ❌ 1 failed · 1 failed, allowed to fail, and after picking1.1.0it read❌ 2 failed. The old code showed 4 failed and 1 allowed in both cases.