Repository navigation
Merged
Conversation
… find the highest tag on cut lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-ups to
--excludeand untagged rows. The report schema stays at 5.Jira links to excluded projects. Each Jira issue's GitLab
linksstill named projects matched by--exclude, and the skill reads those links to say which services an issue touches. Links to excluded projects are now dropped when they are read, in--jiraruns and for the Jira issues found on rows in--group/--projectruns.for_issuesbuilds its projects from the same links, so its separate filter is gone.Untagged count as a lower bound. When the walk stops at
RELEASE_SCOPE_MAX_COMMITSand no row in the range has a tag, more untagged rows may lie below the cut. The page now showsN+ untaggedand "At least N ..." in that case, in English and Russian. This is computed on the page fromtruncatedanduntagged.rows, with no new report field.Next tag when the tag list is cut short. With more tags than the paged list holds, the highest version could be missing, so
next_tagcame out too low. When the list is cut, one more request asks GitLab for tags withorder_by=version&sort=desc(documented indoc/api/tags.md), and those names count toward the highest version. Without a cut, there is no extra request.Each fix started from a failing test, except the page change: the page's JavaScript has no tests, so I checked it in a browser against a sample report. Only a cut range without a tag got the
+; a cut range with a tag and an uncut range kept the exact count.