Repository navigation
test(filter): run a TimeOnly filter on the .NET 6 runtime - #200
Merged
Merged
Conversation
The fix for a TimeOnly value on net6.0 (#176) had no test, because every test project runs on net10.0. QueryKit.Net6Tests runs the net6.0 build of QueryKit on the .NET 6 runtime. The Unit Tests workflow installs the .NET 6 runtime and runs this project. The project is not in QueryKit.sln, so dotnet test at the root does not need the .NET 6 runtime. Without the #176 fix, both filter tests fail with ArgumentNullException: Value cannot be null. (Parameter 'constructor').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for a TimeOnly value on net6.0 (#176) had no test, because every test project runs on net10.0. QueryKit.Net6Tests runs the net6.0 build of QueryKit on the .NET 6 runtime. The Unit Tests workflow installs the .NET 6 runtime and runs this project. The project is not in QueryKit.sln, so dotnet test at the root does not need the .NET 6 runtime.
Without the #176 fix, both filter tests fail with ArgumentNullException: Value cannot be null. (Parameter 'constructor').