Repository navigation
Conversation
…eloaded from memory > exit_5: 0040/0038/11 CV0($string):string CV1($startOffset):int(type_only) CV3($strlen):int(r12:1) CV4($charPos):int(type_only) CV5($foundChars):int(type_only) CV6($invalid):bool CV7($i):int(rcx:1) CV8($char):string CV9($size):int(rdx:1) CV10($j):int(type_only) Inside the JITted loop, `$size` is in a register. At the start of each loop iteration, the compiled code doesn't take `$size` from that register. It reads `$size` from memory. That's because `$size` from before the loop isn't a single type (`[null, long]`) so it cannot be in a register _there_. But at the _end_ of the loop iteration, right when it backedges, JIT doesn't write this back from register into memory... It's kept type-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside the JITted loop,
$sizeis in a register.At the start of each loop iteration, the compiled code doesn't take
$sizefrom that register. It reads$sizefrom memory. That's because$sizefrom before the loop isn't a single type ([null, long]) so it cannot be in a register there. But at the end of the loop iteration, right when it backedges, JIT doesn't write this back from register into memory... It's kept type-only.