Skip to content

Remove dependency on zumba/json-serializer - #678

Open
MauricioFauth wants to merge 1 commit into
phpmyadmin:masterfrom
MauricioFauth:serializer-dep-removal
Open

MauricioFauth wants to merge 1 commit into
phpmyadmin:masterfrom
MauricioFauth:serializer-dep-removal

Conversation

@MauricioFauth

Copy link
Copy Markdown
Member

Instead of deserializing the data and then comparing it with the actual objects, this serializes the actual object and then compares it with the serialized data.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.78%. Comparing base (2e070cd) to head (2e54358).

Files with missing lines Patch % Lines
src/Tools/TestGenerator.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #678      +/-   ##
============================================
+ Coverage     96.03%   96.78%   +0.75%     
+ Complexity     2279     2243      -36     
============================================
  Files            90       90              
  Lines          5041     4951      -90     
============================================
- Hits           4841     4792      -49     
+ Misses          200      159      -41     
Flag Coverage Δ
unit-8.2-ubuntu-latest 96.78% <96.00%> (+0.75%) ⬆️
unit-8.3-ubuntu-latest 96.78% <96.00%> (+0.75%) ⬆️
unit-8.4-ubuntu-latest 96.78% <96.00%> (+0.75%) ⬆️
unit-8.5-ubuntu-latest 96.78% <96.00%> (+0.75%) ⬆️
unit-8.6-ubuntu-latest 96.78% <96.00%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@MauricioFauth
MauricioFauth force-pushed the serializer-dep-removal branch 2 times, most recently from ed72f33 to 6e7d1e0 Compare October 9, 2026 18:53
Instead of deserializing the data and then comparing it with the actual
objects, this serializes the actual object and then compares it with the
serialized data.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
@MauricioFauth
MauricioFauth force-pushed the serializer-dep-removal branch from 6e7d1e0 to 2e54358 Compare October 9, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant