Repository navigation
Make contour grouping matplotlylib tests version-aware - #5799
Merged
camdecoster merged 1 commit intoOct 8, 2026
Merged
Conversation
camdecoster
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #5794
Two tests in matplotlylib's test_renderer are failing on matplotlib version 3.7.5:
matplotlib 3.8 changed how ax.contour exposes its levels. older versions build one line collection per level, while 3.8+ builds a single collection holding all levels. The grouping tests added in #5770 assert that consecutive same-style paths end up in a single trace, which only happens with the single-collection layout. The converted figure is identical on both versions, only the number of traces differs.
Instead of increasing the complexity of the code to enforce similar behaviour of contour grouping on an older matplotlib version, relaxing the test assertions on the older matplotlib version seems like a better approach.