Repository navigation
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22138
mypy infers the arguments of some calls more than once, and narrowing from an assignment expression in one inference stayed in the binder for the next one. The arguments before the assignment, and the assignment's own value, were then inferred with the narrowed type. This happens in:
*args/**kwargs(inferred while mapping actuals to formals)x.append(...)and similar whenxhas a partial typeThis uses the same tool as #20622 used for return values: inferences that are repeated later run in a binder frame with
discard=True. The last inference keeps its narrowing as before: the final check of a generic call, the last item of a union, and the fallback check when no overload item matches. Overloaded calls are the exception, since every item is inferred in a discarded frame. When an overload result is used, the arguments are inferred once more just for the narrowing. This only happens if an assignment expression changed the binder during the call, tracked withassignment_expression_effectfrom #21294, so other calls don't infer their arguments an extra time.