Repository navigation
Say what units sprite velocity and change_angle are in - #2958
Merged
Merged
Conversation
Sprite speeds are per frame at 60 FPS, which the velocity, change_x, change_y and change_angle docstrings didn't say (#2397). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pvcraven
force-pushed
the
sprite-speed-units-docs
branch
from
October 8, 2026 21:23
8de8249 to
9104a3a
Compare
pvcraven
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docstrings only. The sprite speed units weren't documented:
change_xandchange_yjust said "velocity", andchange_anglesaid "per 1/60th of a second".velocity: pixels per frame at 60 FPS, with an example:(5, 0)moves 300 pixels per second to the right.change_xandchange_y: pixels per frame at 60 FPS.change_angle: degrees per frame at 60 FPS.Nothing else changes: no code, no examples. Related to #2397, which stays open for the physics overhaul (#2580).
🤖 Generated with Claude Code