Repository navigation
Allow explicit audio decoders when loading sounds - #2959
Merged
pvcraven merged 1 commit intoOct 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2049.
Allow
arcade.Soundandarcade.load_soundto accept a keyword-onlydecoder: MediaDecoder | Noneand forward it to pyglet's audio loader. Games can select a built-in or custom decoder without subclassingSoundor registering it globally; the default remains automatic selection.Document the argument and a WAV example in the sound guide, and add regression coverage using pyglet's real WAV decoder. The tests cover both loaders, both streaming modes, resource handles and
Pathinputs with an unregistered extension, decoded PCM data, and decoder failures without fallback or changes to exception chaining.Validation on Python 3.12 / Linux with pyglet 3.0.dev11: