Repository navigation
Fix navigation menu showing up empty in Safari - #72
Merged
Merged
Conversation
WyriHaximus
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the menu styles to fix the navigation menu showing up empty in Safari, as reported in #49 back in 2019.
When opening the menu,
ctrly(#42) moves the focus to the close button while the menu is still offscreen, so Safari scrolls the outer menu container sideways and the menu ends up outside of the visible area. Removing the overflow from the outer container fixes this, the inner menu still scrolls just like before. This likely dates back to 2381cc8, which moved the slide-in animation to the inner menu.Confirmed fixed on a real Safari, and I've verified this shows no visible difference anywhere else. The compiled assets have been rebuilt accordingly.
Builds on top of #59 and #42
Resolves #49