Repository navigation
Preserve float precision in RFC 8785 number formatting - #1099
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 8785 §3.2.2.3 requires ECMAScript number serialization. The current
"%.15E"formatting limits numbers to 16 significant digits and can change the underlying double value.0.1 + 0.2is not an RFC test vector, but ECMAScript serializes its result as0.30000000000000004.Float::MAXis covered by Appendix B.Before
After
This replaces
"%.15E"withFloat#to_swhile retaining ECMAScript notation formatting. On CRuby, all Appendix B vectors pass, and 10,000 random finite doubles match Node.js and round-trip correctly.The original implementation also has an open PR addressing the same issue: dryruby/json-canonicalization#6.