Repository navigation
Enforce async correctness and module boundaries with Biome - #1541
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable four focused error-level checks in the frontend lint gate:
noMisusedPromisesrejects promise-valued conditions and async callbacks used by synchronous array methods.useAwaitThenablerejects awaiting synchronous values, including accidentally awaiting a function instead of calling it.noPlaywrightMissingAwaitcatches unawaited browser actions and async assertions.noImportCyclesprevents runtime module cycles while allowing type-only dependencies.The Playwright rule closes a confirmed gap: a temporary unawaited
toBeVisible()assertion imported through our shared fixture failed this rule but passed the existingnoFloatingPromisescheck. The current code already satisfies these rules; no runtime changes or suppressions are needed. Contributor guidance explains the rules and their nursery status.Validation:
npm run format,npm test(Biome, all TypeScript projects, both JS test files), andnpm run buildpassed. Temporary probes confirmed each new rule rejects its target mistake, and valid awaited assertions, returned assertions, and type-only cycles pass; all probes were removed.