Skip to content

refactor(frontend): enable checked indexed access in TypeScript - #1542

Merged
lovasoa merged 2 commits into
mainfrom
codex/ts-checked-indexed-access
Oct 9, 2026
Merged

lovasoa merged 2 commits into
mainfrom
codex/ts-checked-indexed-access

Conversation

@lovasoa

@lovasoa lovasoa commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

TypeScript currently treats an arbitrary array or dictionary lookup as a guaranteed value. Enable noUncheckedIndexedAccess for the frontend and both inherited test configurations so missing entries must be handled explicitly.

The chart label merge now advances narrowed iterator results instead of shifting arrays and casting away possible missing values. Chart palettes use fixed tuples, DOM structure and table sort invariants are checked, and coordinate pairs are narrowed before passing them to Leaflet. Existing assertions now report missing entries without non-null assertions or weakened types. Add coverage for all-empty series and distinct null/zero labels.

Validation:

  • npm run format, npm test, and npm run build
  • All 82 Playwright component fixtures passed using a SQLPage binary built with this branch’s assets.
  • The changed official-site stacked-chart assertion passed.

@lovasoa
lovasoa added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit 4e277b2 Oct 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant