Repository navigation
Conversation
Collaborator
Author
|
sounds uselessly verbose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript previously accepted
{ option: undefined }wherever a configuration property was optional, making it easy to clear library defaults accidentally. EnableexactOptionalPropertyTypesfor the frontend and both inherited test configurations, and build chart points, chart axes, TomSelect settings, and Playwright settings with absent properties when an option is unset.Keep two intentional ApexCharts overrides explicit:
xaxis.typeandtooltip.customuse a presentundefinedto clear defaults. Narrow, documented adapters describe those runtime contracts at the library boundary; omittingtooltip.customwould replace SQLPage's linked range-bar tooltip with ApexCharts' built-in tooltip. Other optional fields retain their exact contracts, and chart type/series assertions exclude undefined because those values are always present.Validation:
npm run format,npm test(Biome, frontend/test TypeScript configurations, frontend unit tests),npm run build, and all 82 Playwright component fixture tests against a binary built with this branch's browser assets.