Skip to content

fix(fetch-content): check the compressed stream's integrity on Windows #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcristau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fetch-content): check the compressed stream's integrity on Windows #1074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/taskgraph/run-task/fetch-content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,10 @@ def extract_stream(reader, dest_dir):
# See extract_archive.
reader.forget()
TarFile.open(fileobj=ifh, mode="r|").extractall(str(dest_dir))
# tarfile stops at the end-of-archive marker, which can leave the
# end of the compressed stream, and its checksum, unread.
while ifh.read(CHUNK_SIZE):
pass
elif magic == ZSTD_MAGIC and shutil.which("zstd"):
# Not tar --use-compress-program: when reading from stdin, tar relays
# it to the decompressor in small blocks, which is several times
Expand Down
Loading