Repository navigation
Fix PHPStan error in wp transient delete - #132
Conversation
Fixes PHPStan error where bool|null was passed to delete_all() and delete_expired(), which expect bool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MLJFdm3myamNTyyrDXQbvh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesTransient deletion
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new defaults do not change the existing deletion behavior for missing or null flags. No actionable merge risk is identified; merge after the normal Composer checks pass. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 PHPStan (2.2.14)Invalid configuration: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The Code Quality workflow on
mainnow fails with:Utils\get_flag_value()is typed as returningnullwhen no default is given. This PR passes an explicitfalsedefault forall,expiredandnetworkinTransient_Command::delete(), matching howlist_()already calls it. Runtime behavior stays the same because the checks usetrue ===, anddelete_all()/delete_expired()already treated a missing flag as falsy.🤖 Generated with Claude Code
https://claude.ai/code/session_01MLJFdm3myamNTyyrDXQbvh
Generated by Claude Code
Summary by CodeRabbit